Add mechanism to handle webhook definitons as part of webhook deployment #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
release-note
tekton-robot
added
the
size/L
nikhil-thomas
force-pushed
the
feature/handle-webhook-definitions
branch
from
1f28821
to
181c41c
Compare
|
/retest |
Add mechanism to webhook controller to create validatingWebhookConfigurations and mutatingWebhookConfigurations right before webhoo registration in webhook deployment. This patch ensures that the names used in the webhookConfigurations remain static without risking edits by OLM Signed-off-by: Nikhil Thomas <nikthoma@redhat.com>
nikhil-thomas
force-pushed
the
feature/handle-webhook-definitions
branch
from
181c41c
to
3dd5646
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: savitaashture The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add mechanism to webhook controller to create
validatingWebhookConfigurations and mutatingWebhookConfigurations right
before webhook registration in webhook deployment.
This patch ensures that the names used in the webhookConfigurations
remain static without risking edits by OLM
Signed-off-by: Nikhil Thomas nikthoma@redhat.com
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes