Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add env to replace the s2i-java env step #939

Merged
merged 1 commit into from Jul 28, 2022
Merged

Add env to replace the s2i-java env step #939

merged 1 commit into from Jul 28, 2022

Conversation

piyush-garg
Copy link
Contributor

Add an env to replace s2i-java env step and make default
related images empty as they are getting appended as part of
script

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

Add env to replace the s2i-java env step

@piyush-garg
Add env to replace the s2i-java env step
0336e88 
Add an env to replace s2i-java env step and make default
related images empty as they are geeting appended as part of
script
@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 28, 2022
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 28, 2022
vdemeester
vdemeester approved these changes Jul 28, 2022
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2022
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2022
@tekton-robot tekton-robot merged commit 53ecee8 into tektoncd:main Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@nikhil-thomas nikhil-thomas Awaiting requested review from nikhil-thomas

@pradeepitm12 pradeepitm12 Awaiting requested review from pradeepitm12

@vincent-pli vincent-pli Awaiting requested review from vincent-pli

Assignees

@vdemeester vdemeester

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@piyush-garg @tekton-robot @vdemeester