-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide the functionality to configure chains through CR #955
Conversation
The following is the coverage report on the affected files.
|
This will add the functionality in chainsCR to have fields from chains-config configmap in it and user can use the fields to provide the value to chains-config configmap Add docs
dfc721f
to
5cefa90
Compare
The following is the coverage report on the affected files.
|
"knative.dev/pkg/apis" | ||
) | ||
|
||
var allowedArtifactsStorage = sets.NewString("tekton", "oci", "gcs", "docdb", "grafeas", "kafka") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏽 😄
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: concaf, sm43 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This will add the functionality in chainsCR to have fields
from chains-config configmap in it and user can use the fields to
provide the value to chains-config configmap
Add docs
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make test lint
before submitting a PRSee the contribution guide for more details.
Release Notes