/
pipelinerun_validation.go
187 lines (155 loc) · 7.12 KB
/
pipelinerun_validation.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
/*
Copyright 2020 The Tekton Authors
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package v1beta1
import (
"context"
"fmt"
"time"
"github.com/google/go-containerregistry/pkg/name"
"github.com/tektoncd/pipeline/pkg/apis/config"
"github.com/tektoncd/pipeline/pkg/apis/validate"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"knative.dev/pkg/apis"
)
var _ apis.Validatable = (*PipelineRun)(nil)
// Validate pipelinerun
func (pr *PipelineRun) Validate(ctx context.Context) *apis.FieldError {
errs := validate.ObjectMetadata(pr.GetObjectMeta()).ViaField("metadata")
if apis.IsInDelete(ctx) {
return nil
}
if pr.IsPending() && pr.HasStarted() {
errs = errs.Also(apis.ErrInvalidValue("PipelineRun cannot be Pending after it is started", "spec.status"))
}
return errs.Also(pr.Spec.Validate(apis.WithinSpec(ctx)).ViaField("spec"))
}
// Validate pipelinerun spec
func (ps *PipelineRunSpec) Validate(ctx context.Context) (errs *apis.FieldError) {
cfg := config.FromContextOrDefaults(ctx)
// Must have exactly one of pipelineRef and pipelineSpec.
if ps.PipelineRef == nil && ps.PipelineSpec == nil {
errs = errs.Also(apis.ErrMissingOneOf("pipelineRef", "pipelineSpec"))
}
if ps.PipelineRef != nil && ps.PipelineSpec != nil {
errs = errs.Also(apis.ErrMultipleOneOf("pipelineRef", "pipelineSpec"))
}
// Validate that a pipelineRef has a name; this may be refactored elsewhere later.
if ps.PipelineRef != nil && ps.PipelineRef.Name == "" {
errs = errs.Also(apis.ErrMissingField("pipelineRef.name"))
}
// If EnableTektonOCIBundles feature flag is on validate it.
// Otherwise, fail if it is present (as it won't be allowed nor used)
if cfg.FeatureFlags.EnableTektonOCIBundles {
// Check that if a pipelineRef.bundle is specified, that a pipelineRef.name is specified as well.
if ps.PipelineRef != nil && ps.PipelineRef.Bundle != "" && ps.PipelineRef.Name == "" {
errs = errs.Also(apis.ErrMissingField("pipelineRef.name"))
}
// If a bundle url is specified, ensure it is parseable.
if ps.PipelineRef != nil && ps.PipelineRef.Bundle != "" {
if _, err := name.ParseReference(ps.PipelineRef.Bundle); err != nil {
errs = errs.Also(apis.ErrInvalidValue("invalid bundle reference", "pipelineRef.bundle", err.Error()))
}
}
} else if ps.PipelineRef != nil && ps.PipelineRef.Bundle != "" {
errs = errs.Also(apis.ErrDisallowedFields("pipelineRef.bundle"))
}
// Validate PipelineSpec if it's present
if ps.PipelineSpec != nil {
errs = errs.Also(ps.PipelineSpec.Validate(ctx).ViaField("pipelineSpec"))
}
if ps.Timeout != nil {
// timeout should be a valid duration of at least 0.
if ps.Timeout.Duration < 0 {
errs = errs.Also(apis.ErrInvalidValue(fmt.Sprintf("%s should be >= 0", ps.Timeout.Duration.String()), "timeout"))
}
}
// This is an alpha feature and will fail validation if it's used in a pipelinerun spec
// when the enable-api-fields feature gate is anything but "alpha".
if ps.Timeouts != nil {
if ps.Timeout != nil {
// can't have both at the same time
errs = errs.Also(apis.ErrDisallowedFields("timeout", "timeouts"))
}
errs = errs.Also(ValidateEnabledAPIFields(ctx, "timeouts", config.AlphaAPIFields))
// tasks timeout should be a valid duration of at least 0.
errs = errs.Also(validateTimeoutDuration("tasks", ps.Timeouts.Tasks))
// finally timeout should be a valid duration of at least 0.
errs = errs.Also(validateTimeoutDuration("finally", ps.Timeouts.Finally))
// pipeline timeout should be a valid duration of at least 0.
errs = errs.Also(validateTimeoutDuration("pipeline", ps.Timeouts.Pipeline))
if ps.Timeouts.Pipeline != nil {
errs = errs.Also(ps.validatePipelineTimeout(ps.Timeouts.Pipeline.Duration, "should be <= pipeline duration"))
} else {
defaultTimeout := time.Duration(config.FromContextOrDefaults(ctx).Defaults.DefaultTimeoutMinutes)
errs = errs.Also(ps.validatePipelineTimeout(defaultTimeout, "should be <= default timeout duration"))
}
}
errs = errs.Also(validateSpecStatus(ctx, ps.Status))
if ps.Workspaces != nil {
wsNames := make(map[string]int)
for idx, ws := range ps.Workspaces {
errs = errs.Also(ws.Validate(ctx).ViaFieldIndex("workspaces", idx))
if prevIdx, alreadyExists := wsNames[ws.Name]; alreadyExists {
errs = errs.Also(apis.ErrGeneric(fmt.Sprintf("workspace %q provided by pipelinerun more than once, at index %d and %d", ws.Name, prevIdx, idx), "name").ViaFieldIndex("workspaces", idx))
}
wsNames[ws.Name] = idx
}
}
return errs
}
func validateSpecStatus(ctx context.Context, status PipelineRunSpecStatus) *apis.FieldError {
switch status {
case "":
return nil
case PipelineRunSpecStatusPending,
PipelineRunSpecStatusCancelledDeprecated:
return nil
case PipelineRunSpecStatusCancelled,
PipelineRunSpecStatusCancelledRunFinally,
PipelineRunSpecStatusStoppedRunFinally:
return ValidateEnabledAPIFields(ctx, "graceful termination", "alpha")
}
cfg := config.FromContextOrDefaults(ctx)
if cfg.FeatureFlags.EnableAPIFields == config.AlphaAPIFields {
return apis.ErrInvalidValue(fmt.Sprintf("%s should be %s, %s, %s or %s", status,
PipelineRunSpecStatusCancelled,
PipelineRunSpecStatusCancelledRunFinally,
PipelineRunSpecStatusStoppedRunFinally,
PipelineRunSpecStatusPending), "status")
}
return apis.ErrInvalidValue(fmt.Sprintf("%s should be %s or %s", status,
PipelineRunSpecStatusCancelledDeprecated,
PipelineRunSpecStatusPending), "status")
}
func validateTimeoutDuration(field string, d *metav1.Duration) (errs *apis.FieldError) {
if d != nil && d.Duration < 0 {
fieldPath := fmt.Sprintf("timeouts.%s", field)
return errs.Also(apis.ErrInvalidValue(fmt.Sprintf("%s should be >= 0", d.Duration.String()), fieldPath))
}
return nil
}
func (ps *PipelineRunSpec) validatePipelineTimeout(timeout time.Duration, errorMsg string) (errs *apis.FieldError) {
if ps.Timeouts.Tasks != nil && ps.Timeouts.Tasks.Duration > timeout {
errs = errs.Also(apis.ErrInvalidValue(fmt.Sprintf("%s %s", ps.Timeouts.Tasks.Duration.String(), errorMsg), "timeouts.tasks"))
}
if ps.Timeouts.Finally != nil && ps.Timeouts.Finally.Duration > timeout {
errs = errs.Also(apis.ErrInvalidValue(fmt.Sprintf("%s %s", ps.Timeouts.Finally.Duration.String(), errorMsg), "timeouts.finally"))
}
if ps.Timeouts.Tasks != nil && ps.Timeouts.Finally != nil {
if ps.Timeouts.Tasks.Duration+ps.Timeouts.Finally.Duration > timeout {
errs = errs.Also(apis.ErrInvalidValue(fmt.Sprintf("%s + %s %s", ps.Timeouts.Tasks.Duration.String(), ps.Timeouts.Finally.Duration.String(), errorMsg), "timeouts.tasks"))
errs = errs.Also(apis.ErrInvalidValue(fmt.Sprintf("%s + %s %s", ps.Timeouts.Tasks.Duration.String(), ps.Timeouts.Finally.Duration.String(), errorMsg), "timeouts.finally"))
}
}
return errs
}