Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dogfood TaskRuns to use generate name #1056

Closed
bobcatfish opened this issue Jul 9, 2019 · 3 comments
Closed

Update dogfood TaskRuns to use generate name #1056

bobcatfish opened this issue Jul 9, 2019 · 3 comments
Labels
area/yamls This issue involves writing a lot of yaml good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@bobcatfish
Copy link
Collaborator

Expected Behavior

Folks releasing Tekton pipelines via https://github.com/tektoncd/pipeline/tree/master/tekton#release-pipeline should be able to run the Runs as-is.

This should apply to all of the -run.yaml TaskRuns in the tekton dir.

Actual Behavior

Folks running these TaskRuns need to make sure to clean up old Runs before/after executing, or the Runs will silently do nothing since they have already completed.

Additional Info

#685 talks about using generateName instead of a hardcoded name which is probably the way to go here!

I would have just made this change while creating the 0.5 release, however I forgot about it and kicked off the TaskRun before I remembered! I'd like whoever does this to verify it actually works before committing it.

@bobcatfish bobcatfish added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. area/yamls This issue involves writing a lot of yaml labels Jul 9, 2019
@bobcatfish bobcatfish self-assigned this Jul 9, 2019
@bobcatfish
Copy link
Collaborator Author

Bahaha my run just failed, I can actually solve this myself XD

@bobcatfish
Copy link
Collaborator Author

Nevermind, I won't do this right now after all, there's an additional complication as @zxDiscovery mentioned at #685 (comment) we have to start using kubectl create instead of kubectl apply; since the -run.yaml files also contain the PipelineResources, calling create on the yaml file as-is leads to failures creating these PipelineResources since they already exist (looking forward to maybe being able to embed PipelineResources via #544 😜 😇 )

@bobcatfish bobcatfish removed their assignment Jul 9, 2019
@bobcatfish
Copy link
Collaborator Author

This isn't required now that we're using tkn and I'm proposing to remove the Runs in #1274

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/yamls This issue involves writing a lot of yaml good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Development

No branches or pull requests

1 participant