Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove kubebuilder (for now) #57

Closed
bobcatfish opened this issue Sep 21, 2018 · 0 comments
Closed

Remove kubebuilder (for now) #57

bobcatfish opened this issue Sep 21, 2018 · 0 comments
Projects
Pipeline CRD
Milestone
Mid October Demo

Comments

@bobcatfish
Copy link
Collaborator

Expected Behavior

While looking into #19 we've decided that for now we want to move forward without kubebuilder (watch #19 for more info re. the rationale) (we might revisit this later afte rfollowing up with kubebuidler folks).

So we would like:

  • build-pipeline's controllers to no longer require kubebuilder
  • Any boilerplate added by kubebuilder that we don't want anymore to be removed
  • Basic skeletons of these controllers to be re-added, but implemented in the same style as the knative/serving and knative/build controllers
  • We should maintain approximately the same level of functionality we currently have, i.e. it is possible to run controllers for all CRDs and perform some very basic validation against them.

We may still want to keep using envtest if it can work without our controllers using controller-runtime, since it's pretty handy to be able to run the controllers in tests without a k8s cluster.

Actual Behavior

Our current controllers were built using kubebuilder v1 and depend on controller-runtime.

Additional Info

See #19 for more.
@bobcatfish bobcatfish added this to To do in Pipeline CRD via automation Sep 21, 2018
@bobcatfish bobcatfish added this to the Mid October Demo milestone Sep 21, 2018
@bobcatfish bobcatfish mentioned this issue Sep 21, 2018
Closed
@bobcatfish bobcatfish moved this from To do to In progress in Pipeline CRD Sep 21, 2018
@aaron-prindle aaron-prindle self-assigned this Sep 21, 2018
@bobcatfish bobcatfish mentioned this issue Sep 22, 2018
Closed
@nader-ziada nader-ziada mentioned this issue Sep 24, 2018
Merged
@bobcatfish bobcatfish moved this from In progress to Needs review in Pipeline CRD Sep 25, 2018
bobcatfish referenced this issue in bobcatfish/pipeline Sep 26, 2018
@bobcatfish
Replace kubebuilder with knative/build style controllers
5182bc5 
This PR removes the kubebuilder dependency and framework from knative/build-pipeline,
opting to instead use the hack/update-codegen.sh scripts approach to generating CRD
libraries. The controller and directory structure were also updated to more closely
mirror knative/build.

Resource was temporarily renamed StandardResource as it collided with a method
Register in pkg/apis/pipeline/v1alpha1/register.go.

Currently tests are stubbed out since all of the existing tests were
kubebuilder specific - we'll have to add more!

Updates developer docs to include how to interact with this repo now
that we've switched styles.

Fixes #57
Pipeline CRD automation moved this from Needs review to Done Sep 26, 2018
This was referenced Sep 26, 2018
Merged
Closed
vdemeester referenced this issue in openshift/tektoncd-pipeline Apr 5, 2019
@aaron-prindle @tejal29 @knative-prow-robot
No kubebuilder (#66)
04831dd 
* Replace kubebuilder with knative/build style controllers

This PR removes the kubebuilder dependency and framework from knative/build-pipeline, opting to instead use the hack/update-codegen.sh scripts approach to generating CRD libraries. The controller and directory structure were also updated to more closely mirror knative/build.

Resource was temporarily renamed StandardResource as it collided with a method
Register in pkg/apis/pipeline/v1alpha1/register.go.

Currently tests are stubbed out since all of the existing tests were
kubebuilder specific - we'll have to add more!

Updates developer docs to include how to interact with this repo now
that we've switched styles.

Fixes #57

* Fix resource version

In our first iteration of the API, we were using `v1beta1` as the
version. We bumped this to `v1alpha1` while removing kubebuilder but
didn't update it everywhere.

Also removed extra references to git-init and creds-init (at the moment we
aren't building these from anything in this repo)

Co-authored-by: Tejal Desai <tejaldesai@google.com>
@vdemeester vdemeester mentioned this issue Oct 8, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Pipeline CRD
  
Done
Milestone
Mid October Demo
Development

No branches or pull requests
2 participants
@bobcatfish @aaron-prindle