Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate deprecated sets.{String,Byte,Int,…} to sets.Sets[String,…] #7374

Open
vdemeester opened this issue Nov 16, 2023 · 2 comments
Open

Migrate deprecated sets.{String,Byte,Int,…} to sets.Sets[String,…] #7374

vdemeester opened this issue Nov 16, 2023 · 2 comments
Assignees
@Dhruval7878
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/misc Categorizes issue or PR as a miscellaneuous one.

Comments

@vdemeester
Copy link
Member

The k8s.io/apimachinery/pkg/util/sets has deprecated the usage of sets.String and its siblings (sets.Byte, …).

Instead, we should use generics, aka sets.Set[string], … see sets.Set.
@vdemeester vdemeester added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/misc Categorizes issue or PR as a miscellaneuous one. labels Nov 16, 2023
@Dhruval7878
Copy link
Contributor

/assign

i am interested in this issue

@chitrangpatel chitrangpatel mentioned this issue Dec 5, 2023
Open
7 tasks
@Dhruval7878
Copy link
Contributor

Dhruval7878 commented Dec 16, 2023 •
edited
Loading

What should I use as a replacement for the return type sets.String in the function ?

and i have used sets.NewString()
do i need to change it to something else

@dhruval254 dhruval254 mentioned this issue Dec 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dhruval7878 Dhruval7878

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/misc Categorizes issue or PR as a miscellaneuous one.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vdemeester @Dhruval7878