Skip to content
This repository has been archived by the owner on Apr 18, 2023. It is now read-only.

Allow global ResolutionRequest timeout to be configured #40

Closed
ghost opened this issue Apr 8, 2022 · 4 comments
Closed

Allow global ResolutionRequest timeout to be configured #40

ghost opened this issue Apr 8, 2022 · 4 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten

Comments

@ghost
Copy link

ghost commented Apr 8, 2022

Feature request

Right now every ResolutionRequest is timed out after 1 minute.

This feature request is to allow an admin to configure this global timeout to be longer or shorter depending on their cluster's needs. Individual resolvers can still set their own timeout for requests (so long as its less than the global one) but this feature is specifically for the global maximum enforced across all requests.

The reason for this global maximum is that it prevents "zombie" requests with a misconfigured resolution.tekton.dev/type label from sticking around in incomplete state forever. It also means that a resolver crashing or hitting errors doesn't put a resolution request in permanent limbo.

Use case

Admins should be able to control the maximum amount of time any resolution request is allowed to take before being marked as "timed out" and failed, thereby also failing the PipelineRun depending on it.

@ghost ghost added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 8, 2022
@tekton-robot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten
Projects
None yet
Development

No branches or pull requests

1 participant