Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial type defintions #10

Closed
bobcatfish opened this issue Jun 23, 2019 · 5 comments
Closed

Add initial type defintions #10

bobcatfish opened this issue Jun 23, 2019 · 5 comments
Assignees
Milestone

Comments

@bobcatfish
Copy link
Collaborator

bobcatfish commented Jun 23, 2019

Expected behavior

We should have the structure of the types we want to add for Tekton Triggers clearly defined in this repo and agreed on by all owners:

  • EventListener
  • TriggerBinding
  • TriggerTemplate

Each type should:

  • Be defined in go such that it can be fed to update-codegen.sh
  • Be agreed on by all owners
  • Be clearly documented in comments (so that it would be fully documented in godoc form)
  • Have an example in an examples dir (even if we aren't testing this yet, see Add automated coverage for examples #11)

Actual behavior

The structure of the types is basically just in exist in example yaml in the design doc which means that:

  1. the actual structure and purpose of each field is not clearly defined
  2. each person reviewing + authoring may have a different idea of what the field actually is

Additional info

Design for these types lives in https://docs.google.com/document/d/1fngeNn3kGD4P_FTZjAnfERcEajS7zQhSEUaN7BYIlTw/edit (visible to members of tekton-dev)

@iancoffey
Copy link
Member

Closed prematurely, theres still items to address despite the PR being merged 😅

@iancoffey iancoffey reopened this Jul 11, 2019
@ncskier
Copy link
Member

ncskier commented Jul 22, 2019

@iancoffey What work is still left under this issue? Is it the work outlined in this comment?

@iancoffey
Copy link
Member

iancoffey commented Jul 22, 2019

@ncskier Yes, I just wanted to make sure I made followup issues if they didnt exist for each of those items (which I have not done yet). Totally cool with closing if thats not needed, or I will check that out tomorrow.

@ncskier
Copy link
Member

ncskier commented Jul 22, 2019

Ok, sounds good! I was just looking over the issues for another one to pick up, and I wasn't positive what was left to do for this one 😁That would be great if you could create new issues documenting the remaining work 👍

@iancoffey
Copy link
Member

This is long since merged, Im going to close this one.

@bobcatfish bobcatfish added this to the Triggers 0.1 milestone Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants