Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automated coverage for examples #11

Closed
bobcatfish opened this issue Jun 23, 2019 · 3 comments
Closed

Add automated coverage for examples #11

bobcatfish opened this issue Jun 23, 2019 · 3 comments
Assignees
Milestone

Comments

@bobcatfish
Copy link
Collaborator

Expected behavior

Any examples we add to the repo should have at least a base level of testing applied to them with each PR, e.g. making sure the structure is sound (even if we don't verify the behavior).

Actual behavior

In #10 we'll be adding types and examples, but we don't yet have any tests for them.

Additional info

@vtereso
Copy link

vtereso commented Aug 5, 2019

/assign

@vtereso
Copy link

vtereso commented Aug 5, 2019

I haven't found any good tooling to help automate the process for when the examples are updated (to avoid copy pasting into the markdown doc files). It would be advantageous to retain the formatting that we get by GitHub's native code fencing so I will make some utilities that will update/check the files for this purpose in addition to asserting the examples in an e2e test.

@dibyom dibyom added this to the Triggers 0.1 milestone Aug 15, 2019
@ncskier
Copy link
Member

ncskier commented Aug 21, 2019

If I'm not mistaken, it looks like this issue is complete. Can we close it? @vtereso

@vtereso vtereso closed this as completed Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants