affinity and podTopologySpread are both rejected by validation webook

[treyhyde]

Expected Behavior

As per https://pkg.go.dev/knative.dev/pkg/apis/duck/v1#PodSpecable, allowed to use keys from https://pkg.go.dev/k8s.io/api/core/v1#PodTemplateSpec in resources.kubernetesResources.spec.templet.spec

It's important to be able to distribute our EL service over multiple AZs and have some sort of availability guarantee, neither affinity or podTopologySpread which allow these guarantees are permitted.

Actual Behavior

cannot patch "fulcrum" with kind EventListener: admission webhook "validation.webhook.triggers.tekton.dev" denied the request: validation failed: must not set the field(s): spec.resources.kubernetesResource.spec.template.spec.affinity, spec.resources.kubernetesResource.spec.template.spec.topologySpreadConstraints
Error: plugin "secrets" exited with error

Steps to Reproduce the Problem

add a EL with

spec:
  resources:
    kubernetesResource:
      replicas: 3
      servicePort: 80
      spec:
        template:
          spec:
            topologySpreadConstraints:
            - maxSkew: 1
              topologyKey: topology.kubernetes.io/zone
              whenUnsatisfiable: DoNotSchedule
              labelSelector:
                matchLabels:
                  eventlistener: my-el-name

Additional Info

• Kubernetes version:
  Client Version: version.Info{Major:"1", Minor:"25", GitVersion:"v1.25.4", GitCommit:"872a965c6c6526caa949f0c6ac028ef7aff3fb78", GitTreeState:"clean", BuildDate:"2022-11-09T13:36:36Z", GoVersion:"go1.19.3", Compiler:"gc", Platform:"darwin/amd64"}
  Kustomize Version: v4.5.7
  Server Version: version.Info{Major:"1", Minor:"24+", GitVersion:"v1.24.7-eks-fb459a0", GitCommit:"c240013134c03a740781ffa1436ba2688b50b494", GitTreeState:"clean", BuildDate:"2022-10-24T20:36:26Z", GoVersion:"go1.18.7", Compiler:"gc", Platform:"linux/amd64"}

• Tekton Pipeline version:
  tkn version
  Client version: 0.29.0
  Pipeline version: v0.40.2
  Triggers version: v0.20.2
  Dashboard version: v0.29.2

[treyhyde]

Slack discussion: https://tektoncd.slack.com/archives/CKUSJ2A5D/p1672767887750569?thread_ts=1672767830.693549&cid=CKUSJ2A5D

[khrm]

/kind feature

[tekton-robot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

[tekton-robot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

[tekton-robot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

[tekton-robot]

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.