Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get end to end tests running against PRs #6

Closed
bobcatfish opened this issue Jun 23, 2019 · 2 comments
Closed

Get end to end tests running against PRs #6

bobcatfish opened this issue Jun 23, 2019 · 2 comments
Milestone

Comments

@bobcatfish
Copy link
Collaborator

Expected behavior

Every PR should have all end to end tests (i.e. tests in the test dir which use the e2e build label) executed against it.

Actual behavior

We don't have any code, or any automation :O

Additional info

@vtereso
Copy link

vtereso commented Jul 8, 2019

Thanks again to @vdemeester for setting this up here

@ncskier
Copy link
Member

ncskier commented Jul 22, 2019

Closing this issue because of the previous comment, and PR #18 adds a basic e2e test for ko apply -f config/

@ncskier ncskier closed this as completed Jul 22, 2019
@bobcatfish bobcatfish added this to the Triggers 0.1 milestone Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants