Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link between cluster interceptor docs and interceptor docs #1074

Merged
merged 1 commit into from
May 5, 2021

Conversation

bobcatfish
Copy link
Collaborator

Changes

I wonder if in the long run it might make sense to merge these pages - hard to understand from just the cluster interceptor docs what the interceptors are about. But for now at least linking to the context.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • [n/a] Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label May 4, 2021
@tekton-robot tekton-robot requested review from dibyom and wlynch May 4, 2021 18:43
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 4, 2021
@jmcshane
Copy link
Contributor

jmcshane commented May 4, 2021

/test pull-tekton-triggers-go-coverage

@jmcshane
Copy link
Contributor

jmcshane commented May 4, 2021

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 4, 2021
@dibyom
Copy link
Member

dibyom commented May 5, 2021

I wonder if in the long run it might make sense to merge these pages - hard to understand from just the cluster interceptor docs what the interceptors are about.

We do have an interceptors page. Maybe we could merge the cluster interceptor stuff in there instead of referencing it in a different doc.

@dibyom
Copy link
Member

dibyom commented May 5, 2021

/approve

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2021
@tekton-robot tekton-robot merged commit 482ea67 into main May 5, 2021
@khrm khrm deleted the bobcatfish-patch-2 branch March 18, 2022 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants