Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving build test issues in PRs #1078

Merged
merged 1 commit into from
May 7, 2021
Merged

Conversation

jmcshane
Copy link
Contributor

@jmcshane jmcshane commented May 7, 2021

Changes

Resolving small build test issues

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

NONE

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 7, 2021
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 7, 2021
@jmcshane jmcshane marked this pull request as draft May 7, 2021 03:45
@jmcshane
Copy link
Contributor Author

jmcshane commented May 7, 2021

@tektoncd/triggers-maintainers this PR just has a single newline and were getting issues with the build tests. im going to change this PR into one that fixes all these issues

@jmcshane
Copy link
Contributor Author

jmcshane commented May 7, 2021

@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 7, 2021
@jmcshane jmcshane changed the title Test Post please ignore - validating build tests Resolving build test issues in PRs May 7, 2021
@tekton-robot tekton-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesnt merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 7, 2021
PRs are failing due to gocritic issues. Resolving these.
@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 7, 2021
@jmcshane jmcshane marked this pull request as ready for review May 7, 2021 12:20
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 7, 2021
@@ -613,7 +613,7 @@ func (r *Reconciler) reconcileCustomObject(ctx context.Context, logger *zap.Suga
}
}

//if dynamicduck.ReconcileCustomObject(existingCustomObject, data) {
// if dynamicduck.ReconcileCustomObject(existingCustomObject, data) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove this comment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe that's a separate PR...not sure the context behind the comment

@dibyom
Copy link
Member

dibyom commented May 7, 2021

/kind cleanup

@tekton-robot tekton-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label May 7, 2021
@dibyom
Copy link
Member

dibyom commented May 7, 2021

/approve

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2021
@dibyom
Copy link
Member

dibyom commented May 7, 2021

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2021
@tekton-robot tekton-robot merged commit d8e21ea into tektoncd:main May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants