Skip *heavy* validation on deletion 🙃

[vdemeester]

Changes

When deleting an object, we don't need to pursue all the validation
that we do at creation. It reduces the work to be done as part of the
validation and allows invalid version of the resource (from previous
versions for example) to be deleted safely.

Signed-off-by: Vincent Demeester vdemeest@redhat.com

The main reasoning for this change is to not face issues to reduce the situation where an upgrade makes object not deletable (because of newly invalid field). The example that happen upgrading from 0.10.x to 0.12.x make EventListener not deletable at all.

/kind bug

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices
• Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

Skip *heavy* validation on deletion in the webhook

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/cluster_interceptor_validation.go	100.0%	90.9%	-9.1
pkg/apis/triggers/v1alpha1/cluster_trigger_binding_validation.go	66.7%	60.0%	-6.7
pkg/apis/triggers/v1alpha1/event_listener_validation.go	97.8%	97.0%	-0.7
pkg/apis/triggers/v1alpha1/trigger_binding_validation.go	100.0%	97.0%	-3.0
pkg/apis/triggers/v1alpha1/trigger_template_validation.go	100.0%	97.1%	-2.9
pkg/apis/triggers/v1alpha1/trigger_validation.go	94.1%	92.9%	-1.3

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dibyom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dibyom]

This is great! Thanks! (Could we add a unit test?)

[vdemeester]

This is great! Thanks! (Could we add a unit test?)

Yeah, I think we can 🙃. Let me look 😉

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/cluster_trigger_binding_validation.go	66.7%	80.0%	13.3
pkg/apis/triggers/v1alpha1/trigger_validation.go	94.1%	94.3%	0.2

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/cluster_trigger_binding_validation.go	66.7%	80.0%	13.3
pkg/apis/triggers/v1alpha1/trigger_validation.go	94.1%	94.3%	0.2

[dibyom]

/lgtm