Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate reconcilers to unversioned packages #1096

Merged
merged 1 commit into from
May 18, 2021

Conversation

dibyom
Copy link
Member

@dibyom dibyom commented May 18, 2021

Changes

Part of refactoring for adding v1beta1 support.
Ref #1067

Signed-off-by: Dibyo Mukherjee dibyo@google.com

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

NONE

Part of refactoring for adding v1beta1 support.
Ref tektoncd#1067

Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 18, 2021
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 18, 2021
@dibyom dibyom added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 18, 2021
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/clusterinterceptor/clusterinterceptor.go Do not exist 90.9%
pkg/reconciler/clusterinterceptor/controller.go Do not exist 0.0%
pkg/reconciler/eventlistener/controller.go Do not exist 100.0%
pkg/reconciler/eventlistener/eventlistener.go Do not exist 78.6%

@dibyom
Copy link
Member Author

dibyom commented May 18, 2021

/test pull-tekton-triggers-integration-tests

@dibyom
Copy link
Member Author

dibyom commented May 18, 2021

/assign @wlynch
/assign @savitaashture

Copy link
Member

@wlynch wlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2021
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wlynch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2021
@tekton-robot tekton-robot merged commit 90f7cca into tektoncd:main May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants