Adds readiness probe in core-interceptors deployment

[sm43]

This adds readiness probe in the core interceptors
deployment.

Closes #1041

Signed-off-by: Shivam Mukhade smukhade@redhat.com

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices
• Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

[dibyom]

Thanks @sm43 We should definitely add a readiness probe. The liveness probe though might need some thinking through - there are cases where it can lead to issues (especially if the readiness and liveness probes are the same) : https://srcco.de/posts/kubernetes-liveness-probes-are-dangerous.html

What do you think about just adding the readiness probe for now and then tackling liveness probe later?

[sm43]

Thanks @sm43 We should definitely add a readiness probe. The liveness probe though might need some thinking through - there are cases where it can lead to issues (especially if the readiness and liveness probes are the same) : https://srcco.de/posts/kubernetes-liveness-probes-are-dangerous.html

What do you think about just adding the readiness probe for now and then tackling liveness probe later?

@dibyom sure. Thanks for sharing the post, didn't knew about it. Updated the PR. :)

[dibyom]

/lgtm

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dibyom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment