Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo for release and interceptors name #1108

Merged
merged 1 commit into from May 24, 2021

Conversation

savitaashture
Copy link
Contributor

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

NONE

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 21, 2021
@tekton-robot tekton-robot requested review from khrm and vtereso May 21, 2021 09:48
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 21, 2021
Copy link
Member

@dibyom dibyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have to re-do any of the previous releases for this? I guess we could just rename the release files in the bucket

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2021
@savitaashture
Copy link
Contributor Author

Do we have to re-do any of the previous releases for this? I guess we could just rename the release files in the bucket

@dibyom No we don't have to because the typo is in result display so it doesn't effect functionality as such
Only thing if someone copy URL from displayed results they get 404 error that is the reason corrected typo.

@nikhil-thomas
Copy link
Member

changes looks good.
@dibyom the filenames/links in gcp bucket and in github release are what we want.

These typos result in printing wrong urls in release-pipeline-results.

@dibyom
Copy link
Member

dibyom commented May 24, 2021

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 24, 2021
@dibyom
Copy link
Member

dibyom commented May 24, 2021

/retest

@dibyom
Copy link
Member

dibyom commented May 24, 2021

/test pull-tekton-triggers-integration-tests

@tekton-robot tekton-robot merged commit 4b26efd into tektoncd:main May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants