Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes the replicas field #1113

Merged
merged 1 commit into from
May 26, 2021
Merged

Removes the replicas field #1113

merged 1 commit into from
May 26, 2021

Conversation

sm43
Copy link
Member

@sm43 sm43 commented May 25, 2021 •
edited
Loading

This remove the deprecated field replicas from spec in eventlistener.

Issue #1020

Signed-off-by: Shivam Mukhade smukhade@redhat.com

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 25, 2021
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 25, 2021
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/triggers/v1alpha1/event_listener_defaults.go 94.4% 91.7% -2.8
pkg/apis/triggers/v1alpha1/event_listener_validation.go 97.8% 97.7% -0.1
test/builder/eventlistener.go 91.5% 93.8% 2.3

@savitaashture
Copy link
Contributor

@sm43 Thank you for the PR
Could you try Upgrade and see no issue with removing deprecated field

dibyom
dibyom reviewed May 25, 2021
View reviewed changes
Copy link
Member

@dibyom dibyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/cc @savitaashture

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 25, 2021
@sm43
Copy link
Member Author

sm43 commented May 25, 2021

@sm43 Thank you for the PR
Could you try Upgrade and see no issue with removing deprecated field

@savitaashture upgrade is fine. didn't faced any issues.

@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label May 26, 2021
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/triggers/v1alpha1/event_listener_defaults.go 94.4% 91.7% -2.8
pkg/apis/triggers/v1alpha1/event_listener_validation.go 97.8% 97.7% -0.1
test/builder/eventlistener.go 91.5% 93.8% 2.3

Removes the replicas field
ab6e8e0 
This remove the deprecated field replicas from spec in eventlistener.

Issue tektoncd#1020

Signed-off-by: Shivam Mukhade <smukhade@redhat.com>
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/triggers/v1alpha1/event_listener_defaults.go 94.4% 91.7% -2.8
pkg/apis/triggers/v1alpha1/event_listener_validation.go 97.8% 97.7% -0.1
test/builder/eventlistener.go 91.5% 93.8% 2.3

savitaashture
savitaashture approved these changes May 26, 2021
View reviewed changes
Copy link
Contributor

@savitaashture savitaashture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2021
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: savitaashture

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2021
@tekton-robot tekton-robot merged commit 6c14687 into tektoncd:main May 26, 2021
@sm43 sm43 mentioned this pull request May 27, 2021
Closed
@sm43 sm43 deleted the remove-replica-field branch August 19, 2021 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dibyom dibyom dibyom left review comments

@savitaashture savitaashture savitaashture approved these changes

@dlorenc dlorenc Awaiting requested review from dlorenc

@ncskier ncskier Awaiting requested review from ncskier

Assignees

@dibyom dibyom

@savitaashture savitaashture

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sm43 @tekton-robot @savitaashture @dibyom