Switch reconciler & sink to using v1beta1 types #1125
Conversation
tekton-robot
added
the
release-note
tekton-robot
added
the
size/XXL
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
The reconciler and sink code now use v1beta1 Triggers types instead of v1alpha1 ones. The v1beta1 type has also been enabled as the storage type. This should be a backwards compatible change. Users should still be able to use the v1alpha1 types as they have before. Part of tektoncd#1067 Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
|
The following is the coverage report on the affected files.
|
|
/test pull-tekton-triggers-integration-tests |
|
/assign @wlynch |
| case i.DeprecatedGitHub != nil: | ||
| if i.DeprecatedGitHub.EventTypes != nil { | ||
| ip["eventTypes"] = i.DeprecatedGitHub.EventTypes | ||
| } | ||
| if i.DeprecatedGitHub.SecretRef != nil { | ||
| ip["secretRef"] = i.DeprecatedGitHub.SecretRef | ||
| } | ||
| case i.DeprecatedGitLab != nil: | ||
| if i.DeprecatedGitLab.EventTypes != nil { | ||
| ip["eventTypes"] = i.DeprecatedGitLab.EventTypes | ||
| } | ||
| if i.DeprecatedGitLab.SecretRef != nil { | ||
| ip["secretRef"] = i.DeprecatedGitLab.SecretRef | ||
| } | ||
| case i.DeprecatedCEL != nil: | ||
| if i.DeprecatedCEL.Filter != "" { | ||
| ip["filter"] = i.DeprecatedCEL.Filter | ||
| } | ||
|
|
||
| if i.DeprecatedCEL.Overlays != nil { | ||
| ip["overlays"] = i.DeprecatedCEL.Overlays | ||
| } | ||
| case i.DeprecatedBitbucket != nil: | ||
| if i.DeprecatedBitbucket.EventTypes != nil { | ||
| ip["eventTypes"] = i.DeprecatedBitbucket.EventTypes | ||
| } | ||
| if i.DeprecatedBitbucket.SecretRef != nil { | ||
| ip["secretRef"] = i.DeprecatedBitbucket.SecretRef | ||
| } |
There was a problem hiding this comment.
Is this a breaking change? is it possible to break this out into its own PR for visibility, or does it need to be coupled with the alpha->beta change?
There was a problem hiding this comment.
It should backwards compatible. Users can still create ELs with the old Deprecated interceptor syntax in the v1alpha1 API group. The defaulting webhook should convert it to the new syntax and the sink code can still work -- this defaulting logic has been around for a couple of releases so as long as the EL was created after v0.13 or after this change should be backwards compatible.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wlynch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
The reconciler and sink code now use v1beta1 Triggers types instead of v1alpha1
ones. The v1beta1 type has also been enabled as the storage type. This should
be a backwards compatible change. Users should still be able to use the
v1alpha1 types as they have before.
Part of #1067
Signed-off-by: Dibyo Mukherjee dibyo@google.com
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes