Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add details to Interceptor docs. #1130

Merged
merged 2 commits into from
Jun 23, 2021
Merged

Add details to Interceptor docs. #1130

merged 2 commits into from
Jun 23, 2021

Conversation

dibyom
Copy link
Member

@dibyom dibyom commented Jun 15, 2021 •
edited
Loading

Changes

This PR adds some additional details on interceptor documentation.

  1. It adds details on how interceptor authors should response when processing should be stopped, and
  2. It clarifies how chaining works with ClusterInterceptors

Fixes #1057
Fixes #1056
Fixes #973

/kind documentation

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/documentation Categorizes issue or PR as related to documentation. labels Jun 15, 2021
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 15, 2021
@dibyom dibyom requested a review from jmcshane June 15, 2021 20:58
@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 15, 2021
@dibyom dibyom changed the title Add details on InterceptorResponse fields Add details to Interceptor docs. Jun 15, 2021
@dibyom
Copy link
Member Author

dibyom commented Jun 16, 2021

/assign @wlynch
/assign @savitaashture

wlynch
wlynch reviewed Jun 16, 2021
View reviewed changes
Copy link
Member

@wlynch wlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

docs/clusterinterceptors.md Outdated Show resolved Hide resolved
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2021
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2021
savitaashture
savitaashture approved these changes Jun 23, 2021
View reviewed changes
Copy link
Contributor

@savitaashture savitaashture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2021
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: savitaashture

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2021
@tekton-robot tekton-robot merged commit 35d290f into tektoncd:main Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wlynch wlynch wlynch left review comments

@savitaashture savitaashture savitaashture approved these changes

@ncskier ncskier Awaiting requested review from ncskier

@jmcshane jmcshane Awaiting requested review from jmcshane

Assignees

@wlynch wlynch

@savitaashture savitaashture

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
4 participants
@dibyom @tekton-robot @wlynch @savitaashture