Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SetSecuritycontext for EventListener in Controller.yaml #1175

Merged
merged 1 commit into from
Aug 16, 2021

Conversation

khrm
Copy link
Contributor

@khrm khrm commented Aug 4, 2021

Put it in the controller.yaml so that a user can refer release.yaml to configure this value instead of digging in the code.
Potentially enable us to run EL in OKD: #1172

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

SetSecuritycontext for EventListener in controller deployment can be configured now.

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 4, 2021
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 4, 2021
@savitaashture
Copy link
Contributor

@khrm even if i set -el-security-context to false in controller.yaml file its alwasy taking value as true only

SetSecuritycontext `el-set-security-context` was missing from
controlley.yaml.
@khrm
Copy link
Contributor Author

khrm commented Aug 16, 2021

@savitaashture I updated controller.yaml file. The way to pass bool is either using =false/true or not passing in case of false.

@savitaashture
Copy link
Contributor

@savitaashture I updated controller.yaml file. The way to pass bool is either using =false/true or not passing in case of false.

Yup it works now as expected 👍

Copy link
Contributor

@savitaashture savitaashture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2021
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: savitaashture

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2021
@tekton-robot tekton-robot merged commit 841ac74 into tektoncd:main Aug 16, 2021
@khrm khrm deleted the addSecurityContext branch February 28, 2023 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants