Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch the secret in only one function #1278

Merged
merged 3 commits into from
Nov 30, 2021

Conversation

guillaumerose
Copy link
Contributor

Changes

Interceptors all fetch the secret the same way. A util function exists
for this purpose interceptors.GetSecretToken. Let's use it for all
implementations.

http.Request is always nil when calling this function. It's something to
fix in the future.

With this single place where the code asks for secret, we can add a
good cache.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Nov 30, 2021
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 30, 2021
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/interceptors/bitbucket/bitbucket.go 92.9% 92.6% -0.3
pkg/interceptors/github/github.go 93.3% 93.1% -0.2
pkg/interceptors/gitlab/gitlab.go 92.9% 92.6% -0.3

Interceptors all fetch the secret the same way. A util function exists
for this purpose `interceptors.GetSecretToken`. Let's use it for all
implementations.

http.Request is always nil when calling this function. It's something to
fix in the future.
When it's impossible to get the secret token, return FailedPrecondition
error code like GitHub implementation.
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/interceptors/bitbucket/bitbucket.go 92.9% 92.6% -0.3
pkg/interceptors/github/github.go 93.3% 93.1% -0.2
pkg/interceptors/gitlab/gitlab.go 92.9% 92.6% -0.3

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: savitaashture

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2021
@dibyom
Copy link
Member

dibyom commented Nov 30, 2021

/lgtm

Thank you for the cleanup!

/kind cleanup

@tekton-robot tekton-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. labels Nov 30, 2021
@tekton-robot tekton-robot merged commit 590de1f into tektoncd:main Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants