Remove replace directives in go.mod #1281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
release-note
tekton-robot
added
the
size/XS
tekton-robot
added
size/M
tekton-robot
added
size/S
There's no context as to why these are pinned. My guess is that this was
for some kind of compatibility issues we've had in the past. Removing
these doesn't seem to have an impact on the build.
My hope is by removing these, we can allow `go install` to function
properly. Currently when you run `go install`, you get the error:
```sh
$ go install github.com/tektoncd/triggers/cmd/binding-eval@latest
go install: github.com/tektoncd/triggers/cmd/binding-eval@latest (in github.com/tektoncd/triggers@v0.17.1):
The go.mod file for the module providing named packages contains one or
more replace directives. It must not contain directives that would cause
it to be interpreted differently than if it were the main module.
```
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
There's no context as to why these are pinned. My guess is that this was
for some kind of compatibility issues we've had in the past. Removing
these doesn't seem to have an impact on the build.
My hope is by removing these, we can allow
go installto functionproperly. Currently when you run
go install, you get the error:$ go install github.com/tektoncd/triggers/cmd/binding-eval@latest go install: github.com/tektoncd/triggers/cmd/binding-eval@latest (in github.com/tektoncd/triggers@v0.17.1): The go.mod file for the module providing named packages contains one or more replace directives. It must not contain directives that would cause it to be interpreted differently than if it were the main module.Provides an alternative for #1279
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes