Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a RegisterInterceptor helper function #1285

Merged
merged 1 commit into from
Dec 16, 2021

Conversation

dibyom
Copy link
Member

@dibyom dibyom commented Dec 15, 2021

Changes

This makes it a lot easier to write custom interceptors while utilizing the
rest of the server helpers that we have created for the packaged core
interceptors.

(Since the interceptors field within Server is not exported, it becomes impossible to use the server code for interceptors not written within the Trigger source tree)

This should help a lot in the process of migrating the dogfooding interceptors in https://github.com/tektoncd/plumbing/tree/main/tekton/ci/interceptors to use the ClusterInterceptor CRD

/cc @afrittoli

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

Adds a RegisterInterceptor helper function that can be used by authors of custom interceptors to utilize the same interceptor server framework that we use for the core interceptors. See https://github.com/tektoncd/plumbing/pull/967 for an example.

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Dec 15, 2021
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 15, 2021
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/interceptors/server/server.go 82.5% 83.7% 1.2

This makes it a lot easier to write custom interceptors while utilizing the
rest of the server helpers that we have created for the packaged core
interceptors.

Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/interceptors/server/server.go 82.5% 83.7% 1.2

Copy link
Contributor

@savitaashture savitaashture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Could you add release note about the RegisterInterceptor.

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: savitaashture

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2021
@dibyom
Copy link
Member Author

dibyom commented Dec 16, 2021

Could you add release note about the RegisterInterceptor.

Done

Copy link
Contributor

@savitaashture savitaashture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2021
@tekton-robot tekton-robot merged commit 13cff21 into tektoncd:main Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants