Add OpenAPI generation and swagger to update-codegen.sh #1297
Conversation
tekton-robot
added
release-note-none
|
/assign @dibyom |
|
The following is the coverage report on the affected files.
|
abayer
force-pushed
the
add-openapi-gen
branch
from
7c75766
to
1b1921d
Compare
|
Oh, and I'll follow this up with a PR like tektoncd/pipeline#4494 to add generated API reference docs. |
|
The following is the coverage report on the affected files.
|
abayer
force-pushed
the
add-openapi-gen
branch
from
1b1921d
to
90fbe16
Compare
|
The following is the coverage report on the affected files.
|
abayer
force-pushed
the
add-openapi-gen
branch
from
90fbe16
to
e3e4dc9
Compare
|
The following is the coverage report on the affected files.
|
And fix tektoncd#1271 along the way by using the same scripting as in tektoncd/pipeline#4402 to ignore API rule violations for `name_match` which already exist. Any new mismatch will cause an error. Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
abayer
force-pushed
the
add-openapi-gen
branch
from
e3e4dc9
to
667c2e8
Compare
|
The following is the coverage report on the affected files.
|
| fmt.Println(string(jsonBytes)) | ||
| } | ||
|
|
||
| func swaggify(name string) string { |
There was a problem hiding this comment.
question: Why do we need to this?
There was a problem hiding this comment.
I literally just copied this over from Pipelines - I assume it does something relating to swagger.json.
There was a problem hiding this comment.
ah ok. was curious as to why we need to have this custom function.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
fyi, once this merges, I'll have another PR that'll generate API reference docs like in tektoncd/pipeline#4494 (though for Pipelines we currently have to use a fork of https://github.com/ahmetb/gen-crd-api-reference-docs because of the |
|
/lgtm |
Changes
And fix #1271 along the way by using the same scripting as in tektoncd/pipeline#4402 to ignore API rule violations for
name_matchwhich already exist. Any new mismatch will cause an error./kind misc
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes