Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the spelling and incorrect article use #1309

Merged
merged 1 commit into from
Feb 10, 2022
Merged

Fix the spelling and incorrect article use #1309

merged 1 commit into from
Feb 10, 2022

Conversation

khrm
Copy link
Contributor

@khrm khrm commented Feb 10, 2022 •
edited
Loading

Changes

Fixes #1307

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

Fix the spelling and incorrect article use.

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 10, 2022
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 10, 2022
@khrm
Copy link
Contributor Author

khrm commented Feb 10, 2022 •
edited
Loading

/kind documentation.

@khrm khrm added the kind/documentation Categorizes issue or PR as related to documentation. label Feb 10, 2022
dibyom
dibyom approved these changes Feb 10, 2022
View reviewed changes
Copy link
Member

@dibyom dibyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 10, 2022
@tekton-robot tekton-robot merged commit bdc195f into tektoncd:main Feb 10, 2022
@khrm khrm deleted the docsParam branch February 28, 2023 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dibyom dibyom dibyom approved these changes

@iancoffey iancoffey Awaiting requested review from iancoffey

@vtereso vtereso Awaiting requested review from vtereso

Assignees

@dibyom dibyom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typo on https://tekton.dev/docs/triggers/triggerbindings/
3 participants
@khrm @tekton-robot @dibyom