Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix integraion Test by upgrading Knative #1616

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Fix integraion Test by upgrading Knative #1616

merged 1 commit into from
Jul 19, 2023

Conversation

khrm
Copy link
Contributor

@khrm khrm commented Jul 18, 2023 •
edited

Knative 1.6 doesn't install on the current cluster. So updated it to the latest version.

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Jul 18, 2023
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 18, 2023
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2023
@khrm
Fix the integraion Test by upgrading Knative
f6a1e4b 
Knative 1.6 doesn't install on the current cluster. So updated it to the latest
version.
@khrm
Copy link
Contributor Author

khrm commented Jul 18, 2023

/kind misc

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Jul 18, 2023
@khrm
Copy link
Contributor Author

khrm commented Jul 18, 2023 •
edited

@bigkevmcd @dibyom Please review and /lgtm to this to fix the integration test.

dibyom
dibyom approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@dibyom dibyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom, savitaashture

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dibyom,savitaashture]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2023
@tekton-robot tekton-robot merged commit ed70653 into tektoncd:main Jul 19, 2023
6 checks passed
@khrm khrm deleted the integrationTest branch October 18, 2023 10:00
@khrm
Copy link
Contributor Author

khrm commented Oct 18, 2023

/cherry-pick release-v0.24.x

@tekton-robot
Copy link

@khrm: new pull request created: #1655

In response to this:

/cherry-pick release-v0.24.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot mentioned this pull request Oct 18, 2023
Merged
@khrm
Copy link
Contributor Author

khrm commented Oct 18, 2023

/cherry-pick release-v0.23.x

@tekton-robot
Copy link

@khrm: new pull request created: #1656

In response to this:

/cherry-pick release-v0.23.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot mentioned this pull request Oct 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dibyom dibyom dibyom approved these changes

@savitaashture savitaashture savitaashture approved these changes

@dlorenc dlorenc Awaiting requested review from dlorenc

Assignees

@dibyom dibyom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@khrm @tekton-robot @dibyom @savitaashture