Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add probes support in Triggers eventlistener #1633

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Add probes support in Triggers eventlistener #1633

merged 1 commit into from
Aug 22, 2023

Conversation

savitaashture
Copy link
Contributor

@savitaashture savitaashture commented Aug 21, 2023 •
edited

Changes

  • Triggers now support probes setting on EventListener object
  • Triggers now have default value for failure-threshold as 3 for both readiness and liveness probes
  • Updated doc with the information of supported fields
  • Added unit test to cover the field set for kubernetes and custom resources

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Triggers now support probes setting on EventListener object
Triggers now have default value for failure-threshold as 3 for both readiness and liveness probes

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 21, 2023
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 21, 2023
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/triggers/v1alpha1/event_listener_validation.go 97.1% 97.3% 0.2
pkg/apis/triggers/v1beta1/event_listener_validation.go 97.2% 97.4% 0.1

@savitaashture
Copy link
Contributor Author

/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 21, 2023
@savitaashture savitaashture removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 21, 2023
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/triggers/v1alpha1/event_listener_validation.go 97.1% 97.2% 0.1
pkg/apis/triggers/v1beta1/event_listener_validation.go 97.2% 97.3% 0.1

khrm
khrm reviewed Aug 21, 2023
View reviewed changes
Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Also, add the point about default failure threshold in the release note.

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2023
@savitaashture savitaashture mentioned this pull request Aug 21, 2023
Closed
7 tasks
@savitaashture
Copy link
Contributor Author

/lgtm

Also, add the point about default failure threshold in the release note.

Added

@savitaashture savitaashture added this to the Triggers v0.25 milestone Aug 22, 2023
khrm
khrm reviewed Aug 22, 2023
View reviewed changes
Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous pr was already approved by @dibyom. Approving this.

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khrm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2023
@savitaashture
Copy link
Contributor Author

/test tekton-triggers-unit-tests

@tekton-robot tekton-robot merged commit b978eab into tektoncd:main Aug 22, 2023
6 checks passed
@savitaashture savitaashture added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khrm khrm khrm approved these changes

@dibyom dibyom Awaiting requested review from dibyom

Assignees

@khrm khrm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Triggers v0.25
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@savitaashture @tekton-robot @khrm