Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump go to 1.21 and pipeline to v0.59.0 LTS #1722

Merged
merged 1 commit into from
May 7, 2024
Merged

Bump go to 1.21 and pipeline to v0.59.0 LTS #1722

merged 1 commit into from
May 7, 2024

Conversation

khrm
Copy link
Contributor

@khrm khrm commented Apr 26, 2024 •
edited
Loading

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Update Go version to 1.21 and Pipelines to v0.59.0. Minimum Kubernetes version is 1.27.

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Apr 26, 2024
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 26, 2024
khrm
khrm commented Apr 26, 2024
View reviewed changes
Copy link
Contributor Author

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/kind misc

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Apr 26, 2024
@khrm
Copy link
Contributor Author

khrm commented Apr 26, 2024

/assign @savitaashture

@khrm
Copy link
Contributor Author

khrm commented Apr 26, 2024

/test tekton-triggers-unit-tests

@khrm
Copy link
Contributor Author

khrm commented Apr 26, 2024

It seems I need to update test go version.

@khrm khrm changed the title Bump pipeline to v0.59.0 LTS Bump go to 1.21 and pipeline to v0.59.0 LTS Apr 26, 2024
@khrm
Copy link
Contributor Author

khrm commented Apr 26, 2024

Should be fixed by tektoncd/plumbing#1938

khrm
khrm commented Apr 26, 2024
View reviewed changes
Copy link
Contributor Author

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest

@khrm
Copy link
Contributor Author

khrm commented Apr 26, 2024

/retest

@khrm
Copy link
Contributor Author

khrm commented Apr 26, 2024

We also need to change replace in go.mod file.

@dibyom
Copy link
Member

dibyom commented May 2, 2024

/test pull-tekton-triggers-build-tests

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 2, 2024
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 6, 2024
@khrm
Copy link
Contributor Author

khrm commented May 6, 2024

/test pull-tekton-triggers-build-tests

@khrm
Copy link
Contributor Author

khrm commented May 6, 2024

/test tekton-triggers-unit-tests

@khrm
Copy link
Contributor Author

khrm commented May 6, 2024

/test pull-tekton-triggers-build-tests

@khrm khrm force-pushed the pipelinev0.59 branch 2 times, most recently from 1ed01fa to b92a417 Compare May 6, 2024 07:18
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/adapter/adapter.go 23.2% 24.1% 0.9

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/adapter/adapter.go 23.2% 24.1% 0.9

@khrm
Copy link
Contributor Author

khrm commented May 6, 2024

/test pull-tekton-triggers-integration-tests

@khrm
Copy link
Contributor Author

khrm commented May 6, 2024

/test pull-tekton-triggers-build-tests

@khrm
Copy link
Contributor Author

khrm commented May 6, 2024

"error: RPC failed; curl 92 HTTP/2 stream 5 was not closed cleanly: CANCEL (err 8)
" Not sure why we are getting this.

@khrm
Copy link
Contributor Author

khrm commented May 6, 2024

/retest-required

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/adapter/adapter.go 23.2% 24.1% 0.9

@khrm
Copy link
Contributor Author

khrm commented May 6, 2024

@savitaashture Can you review this?

savitaashture
savitaashture reviewed May 6, 2024
View reviewed changes
go.mod Show resolved Hide resolved
savitaashture
savitaashture approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@savitaashture savitaashture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2024
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: savitaashture

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2024
@savitaashture savitaashture added this to the Triggers v0.27 milestone May 7, 2024
@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesnt merit a release note. labels May 7, 2024
@tekton-robot tekton-robot merged commit 80048aa into tektoncd:main May 7, 2024
6 checks passed
@khrm khrm deleted the pipelinev0.59 branch May 8, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@savitaashture savitaashture savitaashture approved these changes

@dibyom dibyom Awaiting requested review from dibyom

@iancoffey iancoffey Awaiting requested review from iancoffey

Assignees

@savitaashture savitaashture

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
Triggers v0.27
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@khrm @dibyom @tekton-robot @savitaashture