Fixes for the nightly release process #421
Conversation
tekton-robot
added
the
size/M
|
Looks like some indentation issues in the resources file; otherwise LGTM |
afrittoli
force-pushed
the
fix_release
branch
from
2e32578
to
0139852
Compare
tekton-robot
added
size/L
afrittoli
force-pushed
the
fix_release
branch
from
0139852
to
4427cf4
Compare
Move run resources to a dedicated folder, so they are not applied by mistake when doing `kubectl apply -f tekton`. Make the bucket resource name unique so that it does not conflict. Point the bucket directly into the triggers folder, to avoid downloading the releases of all tekton projects - making the release process more separated from other projects release process, so we don't have an issue if the releases run in parallel. Remove `triggers` from the path when copying to the bucket. Add a cloudevent resource to trigger post release services (log copy).
afrittoli
force-pushed
the
fix_release
branch
from
4427cf4
to
69163dc
Compare
|
/test pull-tekton-triggers-build-tests |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| - name: url | ||
| value: cmd/eventlistenersink # Registry is provided via parameter, this is a hack see #569 | ||
| # --- |
There was a problem hiding this comment.
Was this meant to be commented out?
There was a problem hiding this comment.
Yeah, the URL of the sink there is cluster specific so I didn't want to include a resource that would actually be applied with a broken url
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Changes
Move run resources to a dedicated folder, so they are not applied
by mistake when doing
kubectl apply -f tekton.Make the bucket resource name unique so that it does not conflict.
Point the bucket directly into the triggers folder, to avoid
downloading the releases of all tekton projects - making the release
process more separated from other projects release process, so we
don't have an issue if the releases run in parallel.
Remove
triggersfrom the path when copying to the bucket.Add a cloudevent resource to trigger post release services (log copy).
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes