Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated Params field from EventListener #444

Merged
merged 1 commit into from
Feb 18, 2020
Merged

Remove deprecated Params field from EventListener #444

merged 1 commit into from
Feb 18, 2020

Conversation

dibyom
Copy link
Member

@dibyom dibyom commented Feb 14, 2020 •
edited
Loading

Changes

The field was replaced with static binding values in TriggerBindings.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

The deperecated Params field has been removed from the EventListener. Use a TriggerBinding with static values instead.

@dibyom
Remove deprecated Params field from EventListener
09b3f5b 
The field was replaced with static binding values in TriggerBindings.

Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 14, 2020
@iancoffey
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2020
@dibyom dibyom added this to the Triggers 0.3 milestone Feb 18, 2020
@dibyom dibyom requested review from ncskier and wlynch and removed request for dlorenc February 18, 2020 18:11
wlynch
wlynch reviewed Feb 18, 2020
View reviewed changes
Copy link
Member

@wlynch wlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wlynch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2020
@tekton-robot tekton-robot merged commit c6ddf3b into tektoncd:master Feb 18, 2020
@dibyom dibyom deleted the params branch February 19, 2020 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wlynch wlynch wlynch left review comments

@iancoffey iancoffey Awaiting requested review from iancoffey

@ncskier ncskier Awaiting requested review from ncskier

Assignees

@iancoffey iancoffey

@wlynch wlynch

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
Triggers 0.3
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dibyom @iancoffey @tekton-robot @wlynch @googlebot