Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo cel interceptor example. #446

Merged
merged 1 commit into from
Feb 19, 2020
Merged

Fix typo cel interceptor example. #446

merged 1 commit into from
Feb 19, 2020

Conversation

bigkevmcd
Copy link
Member

@bigkevmcd bigkevmcd commented Feb 18, 2020 •
edited
Loading

Changes

The HTTP headers are available via the 'header' not 'headers'.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 18, 2020
@bigkevmcd
Copy link
Member Author

/retest all

@bigkevmcd
Copy link
Member Author

/retest

@ncskier
Copy link
Member

ncskier commented Feb 18, 2020

/test pull-tekton-triggers-build-tests

@dibyom
Copy link
Member

dibyom commented Feb 18, 2020

/lgtm
/approve

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 18, 2020
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2020
@dibyom
Copy link
Member

dibyom commented Feb 18, 2020

Looks like this needs a rebase now @bigkevmcd

@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 18, 2020
@bigkevmcd
Fix typo in CEL interceptor example.
7b8b419 
The HTTP headers are available via the 'header' not 'headers'.
@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 18, 2020
@dibyom
Copy link
Member

dibyom commented Feb 19, 2020

/test pull-tekton-triggers-integration-tests

@khrm
Copy link
Contributor

khrm commented Feb 19, 2020

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2020
@tekton-robot tekton-robot merged commit 28e9922 into tektoncd:master Feb 19, 2020
@bigkevmcd bigkevmcd deleted the fix-headers-typo branch March 10, 2020 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dibyom dibyom Awaiting requested review from dibyom

@iancoffey iancoffey Awaiting requested review from iancoffey

Assignees

@khrm khrm

@dibyom dibyom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@bigkevmcd @ncskier @dibyom @tekton-robot @khrm @googlebot