Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow creating v1beta1 resources #490

Merged
merged 1 commit into from
Mar 24, 2020
Merged

Allow creating v1beta1 resources #490

merged 1 commit into from
Mar 24, 2020

Conversation

dibyom
Copy link
Member

@dibyom dibyom commented Mar 19, 2020 •
edited
Loading

Changes

  • Update examples to use v1beta1 by default.
  • Add an explicit v1alpha1 example.
  • Use v1beta1 Pipeline types for Params and tests.

Fixes #481

Followup cleanup: #494

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

Triggers can now create both v1alpha1 and v1beta1 Pipeline resources.

@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 19, 2020
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 19, 2020
@dibyom dibyom marked this pull request as ready for review March 23, 2020 18:51
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 23, 2020
@dibyom dibyom mentioned this pull request Mar 23, 2020
Closed
ncskier
ncskier requested changes Mar 23, 2020
View reviewed changes
Copy link
Member

@ncskier ncskier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dibyom, looks great! Just a few comments/change requests.

examples/v1alpha1/README.md Outdated Show resolved Hide resolved
examples/v1alpha1/README.md Outdated Show resolved Hide resolved
pkg/sink/sink_test.go Show resolved Hide resolved
@dibyom dibyom requested a review from ncskier March 23, 2020 22:11
@dibyom dibyom mentioned this pull request Mar 23, 2020
Merged
5 tasks
ncskier
ncskier requested changes Mar 24, 2020
View reviewed changes
Copy link
Member

@ncskier ncskier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! Just one more thing with the new changes.

examples/v1alpha1-task/README.md Outdated Show resolved Hide resolved
@dibyom
Allow creating v1beta1 resources
2bdfd18 
- Update examples to use v1beta1 by default.
- Add an explicit v1alpha1 example.
- Use v1beta1 Pipeline types for Params and tests.

Fixes tektoncd#481

Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
ncskier
ncskier approved these changes Mar 24, 2020
View reviewed changes
Copy link
Member

@ncskier ncskier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2020
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncskier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2020
@tekton-robot tekton-robot merged commit 28e6565 into tektoncd:master Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncskier ncskier ncskier approved these changes

@wlynch wlynch Awaiting requested review from wlynch

Assignees

@ncskier ncskier

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support creating v1beta1 Pipeline resources
4 participants
@dibyom @tekton-robot @ncskier @googlebot