Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs to specify k8s version 1.15 or greater #519

Merged
merged 1 commit into from
Apr 6, 2020

Conversation

ncskier
Copy link
Member

@ncskier ncskier commented Apr 6, 2020

Changes

Fixes #517

Triggers now requires kubernetes version 1.15 or higher; this PR updates
the docs to reflect this.

/cc @dibyom
/cc @joe-sonrichard

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

Updates the minimum k8s version in the docs to 1.15.

Fixes tektoncd#517

Triggers now requires kubernetes version 1.15 or higher; this PR updates
the docs to reflect this.
@tekton-robot
Copy link

@ncskier: GitHub didn't allow me to request PR reviews from the following users: joe-sonrichard.

Note that only tektoncd members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Changes

Fixes #517

Triggers now requires kubernetes version 1.15 or higher; this PR updates
the docs to reflect this.

/cc @dibyom
/cc @joe-sonrichard

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

Updates the minimum k8s version in the docs to 1.15.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot requested a review from dibyom April 6, 2020 18:15
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 6, 2020
@dibyom
Copy link
Member

dibyom commented Apr 6, 2020

/approve
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2020
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2020
@tekton-robot tekton-robot merged commit e79fe5a into tektoncd:master Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v0.4.0-rc1 requires k8s version 1.15.0+ but docs don't say so
4 participants