Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect split example #520

Merged
merged 1 commit into from
Apr 6, 2020
Merged

Fix incorrect split example #520

merged 1 commit into from
Apr 6, 2020

Conversation

dibyom
Copy link
Member

@dibyom dibyom commented Apr 6, 2020 •
edited
Loading

Changes

Also, adds a unit test that combines split and truncate.

Fixes #518

Thanks to @ymatsush for finding and fixing the example!

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 6, 2020
@dibyom
Copy link
Member Author

dibyom commented Apr 6, 2020

/hold
prettier messed up some of the docs formatting :(

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 6, 2020
@dibyom
Fix incorrect split example
1ffcdbf 
Also, adds a unit test that combines split and truncate.

Fixes tektoncd#518

Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 6, 2020
@dibyom
Copy link
Member Author

dibyom commented Apr 6, 2020

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 6, 2020
@dibyom dibyom requested a review from ncskier April 6, 2020 21:16
ncskier
ncskier approved these changes Apr 6, 2020
View reviewed changes
Copy link
Member

@ncskier ncskier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2020
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncskier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2020
@tekton-robot tekton-robot merged commit b85308d into tektoncd:master Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncskier ncskier ncskier approved these changes

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

@vtereso vtereso Awaiting requested review from vtereso

Assignees

@ncskier ncskier

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

found no matching overload for 'truncate' (split) in example yaml
4 participants
@dibyom @tekton-robot @ncskier @googlebot