Remove linting from release pipeline 馃Ч #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linting should never fail on a release Pipeline since any issues should be caught in the PR. This linting is failing in the nightly release pipeline for unknown reasons so let's remove it. We can keep debugging the issue if we encounter it again somewhere that we actually need it. I tested this by manually applying the pipelines and manually triggering the nightly cron: ``` k --context dogfood create job --from cronjob/nightly-cron-trigger-triggers-nightly-release nightly-cron-trigger-triggers-nightly-release-manual-05282020 ``` Fixes tektoncd/plumbing#403
tekton-robot
added
the
size/S
dibyom
approved these changes
May 28, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Good question - its removed from pipelines, maybe it makes sense to do the others as well 馃 Or we could wait until it causes a problem and remove it then? |
|
(that's probably just me being lazy 馃槄 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Linting should never fail on a release Pipeline since any issues should
be caught in the PR. This linting is failing in the nightly release
pipeline for unknown reasons so let's remove it. We can keep debugging
the issue if we encounter it again somewhere that we actually need it.
I tested this by manually applying the pipelines and manually triggering
the nightly cron:
Fixes tektoncd/plumbing#403
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.