-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add nodeSelector and replicas to eventlistener #625
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
--- | ||
apiVersion: triggers.tekton.dev/v1alpha1 | ||
kind: EventListener | ||
metadata: | ||
name: listener-podtemplate | ||
spec: | ||
serviceAccountName: tekton-triggers-example-sa | ||
podTemplate: | ||
nodeSelector: | ||
app: test | ||
triggers: | ||
- name: foo-trig | ||
bindings: | ||
- ref: pipeline-binding | ||
- ref: message-binding | ||
template: | ||
name: pipeline-template |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
--- | ||
apiVersion: triggers.tekton.dev/v1alpha1 | ||
kind: EventListener | ||
metadata: | ||
name: listener-replicas | ||
spec: | ||
serviceAccountName: tekton-triggers-example-sa | ||
replicas: 3 | ||
triggers: | ||
- name: foo-trig | ||
bindings: | ||
- ref: pipeline-binding | ||
- ref: message-binding | ||
template: | ||
name: pipeline-template |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -34,6 +34,6 @@ type LRUCache interface { | |
// Clears all cache entries. | ||
Purge() | ||
|
||
// Resizes cache, returning number evicted | ||
Resize(int) int | ||
// Resizes cache, returning number evicted | ||
Resize(int) int | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👀 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this is because I ran one of the scripts in |
||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should Replica be part of PodTemplate? Maybe in future have a ducktype like PodSpecable mentioned here:
#505 (comment)
Of course, we want to give only limited set of capability even if we do ducktype.
@dibyom
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, my understanding is that for PodTemplate or PodSpecable, the object can contain fields from a
PodSpec
: https://godoc.org/k8s.io/api/core/v1#PodSpecreplicas
are part of the DeploymentSpec -> looking through the fields it doesn't seems like we'd want to support customizing any fields besidesreplicas
. So, maybe we just leavereplicas
as part of the EL spec (maybe we can call itdeploymentReplicas
?) What do you think @khrm ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add this to tomorrow's WG agenda. Unless there are objections, I feel inclined to keep the current field naming!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks :) @dibyom