Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs and examples to use ref instead of name for bindings #645

Merged
merged 1 commit into from Jun 29, 2020

Conversation

savitaashture
Copy link
Contributor

@savitaashture savitaashture commented Jun 29, 2020

Changes

  1. Updated examples and docs to use ref instead of name for bindings
  2. Updated signature value in GH README because CEL filters are added as part of this PR Add cel filter for pull request actions in github example #637 which resulted signature validation failure.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 29, 2020
@dibyom
Copy link
Member

dibyom commented Jun 29, 2020

Thanks @savitaashture
/approve
/lgtm
/kind documentation

@tekton-robot tekton-robot added kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. labels Jun 29, 2020
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2020
@tekton-robot tekton-robot merged commit 3d474d4 into tektoncd:master Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants