Expose the incoming request URL to CEL expressions.

[bigkevmcd]

Changes

This adds a requestURL key to the CEL expression context.

For example, requestURL.parseURL().path would get the path of the incoming request URL.

Fixes: #640

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices

See the contribution guide for more details.

Release Notes

This adds a `requestURL` key to the CEL expression context.

For example, `requestURL.parseURL().path` would get the path of the incoming request URL.

[dibyom]

So, this adds requestURL to the CEL context. Wondering if it makes sense to add it to the TriggerBinding context as well -- I guess the only use case right now would be to use the entire url...unless we add CEL functions to TriggerBindings

/approve
/kind feature

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dibyom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[bigkevmcd]

So, this adds requestURL to the CEL context. Wondering if it makes sense to add it to the TriggerBinding context as well -- I guess the only use case right now would be to use the entire url...unless we add CEL functions to TriggerBindings

There's arguably value in having the requestURL in trigger bindings, if CEL functions landed in TriggerBindings, I'd be looking to refactor and reuse the same context mechanism.

[dibyom]

Yeah, let's just go with the CEL context for now.

[dibyom]

/lgtm

[lostiniceland]

I was hoping to parse query parameters using this function to easily trigger a pipeline in tekton (no need for curl or postman etc, just a browser).
I am able to use the cel filter in an EventListener but without support for this in a TriggerBinding it is useless for my case

[bigkevmcd]

@lostiniceland you can expose the elements you need as overlays via a CEL interceptor and then use those in a binding https://tekton.dev/docs/triggers/interceptors/#cel-interceptors and https://tekton.dev/docs/triggers/triggerbindings/#accessing-data-added-by-interceptorsdocstriggersinterceptors ?