Provide the incoming EventListener URL to the Webhook Interceptor. #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
size/S
|
The following is the coverage report on the affected files.
|
|
/kind feature |
tekton-robot
added
the
kind/feature
dibyom
approved these changes
Jul 9, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
@bigkevmcd thanks, you might have to force push to get the easy CLA bot run again |
Webhook Interceptors can parse the `EventListener-Request-URL` if they want to extract parameters from the original request URL being handled by the EventListener. Co-authored-by: savitaashture <sashture@redhat.com>
bigkevmcd
force-pushed
the
pass-url-to-webhook-interceptor
branch
from
0012c64
to
4f6e29d
Compare
|
The following is the coverage report on the affected files.
|
|
/lgtm |
|
/test pull-tekton-triggers-build-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Webhook Interceptors can parse the
EventListener-Request-URLif they want toextract parameters from the original request URL being handled by the
EventListener.
Fixes: #667
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes