-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Incorrect number of response for Forbidden err #673
Conversation
The following is the coverage report on the affected files.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks. Could we add a test for this?
Stale issues rot after 30d of inactivity. /lifecycle rotten Send feedback to tektoncd/plumbing. |
Rotten issues close after 30d of inactivity. /close Send feedback to tektoncd/plumbing. |
@tekton-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is still technically a bug. @khrm how do we want to proceed here? Would it be hard to add a test in the sink package? |
/kind bug |
The following is the coverage report on the affected files.
|
Sorry, I didn't notice it wasn't merge. I would add a test today. |
The following is the coverage report on the affected files.
|
When forbidden error happens, number of response are more than number of trigger in EL Spec. This patch returns immediately from goroutine when Forbidden err happens.
The following is the coverage report on the affected files.
|
@dibyom I added a test for Forbidden Status but issue is testing the number of responses. That's proving to be difficult. |
Well, this is still an improvement in terms of test coverage so thanks! /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
When forbidden error happens, number of response are more than number
of trigger in EL Spec. This patch returns immediately from goroutine
when Forbidden err happens.
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes