Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dep: update golang.org/x/text to v0.3.3 #674

Merged
merged 1 commit into from Jul 10, 2020

Conversation

vdemeester
Copy link
Member

Changes

An issue in golang.org/x/text can lead to infinit loop and cause
crashes, see golang/go#39491.
This "force" bump the dependency to v0.3.3 that contains the fix.

Signed-off-by: Vincent Demeester vdemeest@redhat.com

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

An issue in golang.org/x/text can lead to infinit loop and cause
crashes, see golang/go#39491.
This "force" bump the dependency to v0.3.3 that contains the fix.

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 10, 2020
@dibyom
Copy link
Member

dibyom commented Jul 10, 2020

Thanks!
/lgtm
/approve

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2020
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2020
@tekton-robot tekton-robot merged commit 232cc69 into tektoncd:master Jul 10, 2020
@vdemeester vdemeester deleted the bump-golang-x-text branch July 10, 2020 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants