Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix install links for nginx ingress for GKE #685

Merged
merged 1 commit into from Jul 28, 2020
Merged

Fix install links for nginx ingress for GKE #685

merged 1 commit into from Jul 28, 2020

Conversation

dibyom
Copy link
Member

@dibyom dibyom commented Jul 23, 2020

Changes

The old URLs were returning 404s.
Also, link to the website for other installation options

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

/kind documentation

@dibyom
Fix install links for nginx ingress for GKE
60f6f12 
The old URLs were returning 404s.
Also, link to the website for other installation options
@dibyom dibyom requested a review from wlynch July 23, 2020 18:08
@tekton-robot tekton-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Jul 23, 2020
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 23, 2020
@savitaashture
Copy link
Contributor

Thank you 👍

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2020
@wlynch
Copy link
Member

wlynch commented Jul 28, 2020

/lgtm
/approve

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wlynch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2020
@tekton-robot tekton-robot merged commit a088435 into master Jul 28, 2020
@dibyom dibyom deleted the dibyom-patch-2 branch December 1, 2020 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wlynch wlynch Awaiting requested review from wlynch

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

@iancoffey iancoffey Awaiting requested review from iancoffey

Assignees

@wlynch wlynch

@savitaashture savitaashture

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dibyom @savitaashture @wlynch @tekton-robot