Fix GitHub example bindings #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
size/M
| type: git | ||
| params: | ||
| - name: revision | ||
| value: $(params.gitrevision) |
There was a problem hiding this comment.
Nice fix 👍 how its use to work earlier 🤔
small changes related to tt.params
Suggested change
| value: $(params.gitrevision) | |
| value: $(tt.params.gitrevision) |
There was a problem hiding this comment.
Done!
We were using a mock/fake body to test this example out. Turns out that body was wrong -- it was for the push event not pull_request too. So, the example worked. When tried with a real GitHub PR, it failed 😅
The old bindings were for the GitHub push event while this EventListener is configured for pull_request event types. See: https://developer.github.com/webhooks/event-payloads/#pull_request
tekton-robot
added
size/L
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wlynch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The old bindings were for the GitHub push event while this EventListener is
configured for pull_request event types. See:
https://developer.github.com/webhooks/event-payloads/#pull_request
(I also moved the bindings and template to the same file to be consistent with the GitLab example)
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes