-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add namespace to the commands in Nginx ingress doc #698
Conversation
Hi @NavidZ. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign dibyom |
/ok-to-test |
docs/exposing-eventlisteners.md
Outdated
```sh | ||
kubectl get el <EVENTLISTENR_NAME> -o=jsonpath='{.status.configuration.generatedName}' | ||
kubectl get el <EVENTLISTENR_NAME> -n getting-started -o=jsonpath='{.status.configuration.generatedName}{"\n"}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this. Usually in most of our examples/snippets, we generally omit the namespace parameter since it is a common parameter that applies to almost all kubectl commands. However, I do realize that it is confusing for users following the getting-started
tutorial since it uses a non-default namespace. What do you think of having both i.e. one snippet with no namespace with a note/comment below with an example mentioning that users should add a -n <namespace>
param for their commands if needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with you. I realized people might be coming here from other places beside the tutorial. But then I saw the yaml right after this that installs Ingress in getting-started namespace. So I thought maybe not.
But I'm totally fine with your solution. what should we do with the Ingress resource?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with a quick note there to indicate that namespace might be needed too!
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add namespace to the commands in Nginx ingress doc to get
them to work.