Cleanup Reconciler Tests in order to pick up Genreconciler updates

[dibyom]

Changes

This PR has two commits and is needed for #635 :

Merge service and deployment tests into TestReconcile

We had separate tests for reconcileService and reconcileDeployment. These tests
were hard to port with the genreconciler update(#635) which changes the Reconciler
interface. Instead of testing these unexported functions, I merged the test
cases for these into the existing TestReconcile function

Make reconciler tests more readable …

The reconciler tests used variables of the form service1, deployment2 etc.
making it hard to figure out what those objects actually did. This change does
the following:

1. Adds more descriptive names e.g. eventListenerWithNodeSelector instead of
   eventlistener6

2. Adds helper functions makeEL, makeDeployment,
   makeService to create the above objects instead of deep-copying and changing
   values

3. Fixes a bug I found in the process: The tests were setting the
   generatedResourceName in the status of the pre-reconciled resource. Instead it
   should be set by the Reconciler. Without this, we weren't actually testing if
   the status contained the right generatedResourceName

/kind cleanup

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices

See the contribution guide for more details.

Release Notes

NONE

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/v1alpha1/eventlistener/eventlistener.go	70.8%	72.5%	1.8

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/v1alpha1/eventlistener/eventlistener.go	70.8%	72.5%	1.8

[dibyom]

/assign @khrm
/assign @wlynch

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/v1alpha1/eventlistener/eventlistener.go	70.8%	72.5%	1.8

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/v1alpha1/eventlistener/eventlistener.go	70.8%	72.5%	1.8

[savitaashture]

/lgtm

[wlynch]

Bleh - This is still a bit hard to follow, since the transformation from start to end state are still somewhat obscured since they are not localized with the tests themselves.

That said, this is definitely an improvement from the previous state, so lgtm!

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wlynch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [wlynch]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dibyom]

Bleh - This is still a bit hard to follow, since the transformation from start to end state are still somewhat obscured since they are not localized with the tests themselves.

Yeap, next PR is to fix that 😄

[dibyom]

/test tekton-triggers-unit-tests