Mark some command tests as end-to-end #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
size/XS
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: khrm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm Thank you 👍 |
Those tests require a living cluster (with tekton installed), this means they are end-to-end tests. Adding the `e2e` build tag on them so they don't get executed while doing unit tests. Also, run those as part of the e2e script. Signed-off-by: Vincent Demeester <vincent@sbr.pm>
vdemeester
force-pushed
the
cmd-e2e-tests
branch
from
037fd8c
to
28bbba3
Compare
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Those tests require a living cluster (with tekton installed), this
means they are end-to-end tests. Adding the
e2ebuild tag on them sothey don't get executed while doing unit tests.
Also, run those as part of the e2e script.
Signed-off-by: Vincent Demeester vincent@sbr.pm
/cc @dibyom @savitaashture @khrm @wlynch
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes