Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitbucket example README update #724

Merged
merged 1 commit into from
Aug 21, 2020

Conversation

savitaashture
Copy link
Contributor

Changes

  1. Updated bitbucket triggerbinding to point http instead of ssh.
  2. Updated repository data for bitbucket readme in the format it comes from bitbucket server.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

None

@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 20, 2020
@dibyom
Copy link
Member

dibyom commented Aug 21, 2020

/kind documentation

@tekton-robot tekton-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Aug 21, 2020
@dibyom
Copy link
Member

dibyom commented Aug 21, 2020

/approve

Just one question: What is the motivation behind this change?

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2020
Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2020
@khrm khrm removed the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2020
@savitaashture
Copy link
Contributor Author

savitaashture commented Aug 21, 2020

Just one question: What is the motivation behind this change?

@dibyom

  1. The changes are just to make sure README is in align with the actual output from bitbucket server
    actually when i started testing with real bitbucket server i observed that the response coming in this way
				"links": {
					"clone": [{
						"href": "http://bitbucket-service-bitbucket.apps.cicd.tekton.codereadyqe.com/scm/hel/firstapp.git",
						"name": "http"
					}, {
						"href": "ssh://git@bitbucket-service-bitbucket.apps.cicd.tekton.codereadyqe.com/hel/firstapp.git",
						"name": "ssh"
					}],
					"self": [{
						"href": "http://bitbucket-service-bitbucket.apps.cicd.tekton.codereadyqe.com/projects/HEL/repos/firstapp/browse"
					}]
				}

But in README i have kept clone data in apposite way so in order to make sync modified this way

  1. In triggerbinding gitrepositoryurl always pointing to ssh but sometime ssh require extra credential management so in order to make it simple modified to point to http

@khrm
Copy link
Contributor

khrm commented Aug 21, 2020

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2020
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2020
@vdemeester
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2020
@tekton-robot tekton-robot merged commit 4a56bba into tektoncd:master Aug 21, 2020
@dibyom
Copy link
Member

dibyom commented Aug 21, 2020

Just one question: What is the motivation behind this change?

@dibyom

  1. The changes are just to make sure README is in align with the actual output from bitbucket server
    actually when i started testing with real bitbucket server i observed that the response coming in this way
				"links": {
					"clone": [{
						"href": "http://bitbucket-service-bitbucket.apps.cicd.tekton.codereadyqe.com/scm/hel/firstapp.git",
						"name": "http"
					}, {
						"href": "ssh://git@bitbucket-service-bitbucket.apps.cicd.tekton.codereadyqe.com/hel/firstapp.git",
						"name": "ssh"
					}],
					"self": [{
						"href": "http://bitbucket-service-bitbucket.apps.cicd.tekton.codereadyqe.com/projects/HEL/repos/firstapp/browse"
					}]
				}

But in README i have kept clone data in apposite way so in order to make sync modified this way

  1. In triggerbinding gitrepositoryurl always pointing to ssh but sometime ssh require extra credential management so in order to make it simple modified to point to http

Thanks for the clarification!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants