Add basic syntactical parsing of CEL filters and expressions. #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
release-note
tekton-robot
added
the
size/S
|
The following is the coverage report on the affected files.
|
savitaashture
requested changes
Sep 7, 2020
| for _, v := range i.CEL.Overlays { | ||
| _, issues := env.Parse(v.Expression) | ||
| if issues != nil && issues.Err() != nil { | ||
| return apis.ErrInvalidValue(fmt.Errorf("failed to parse the CEL filter: %s", issues.Err()), "cel.filter") |
There was a problem hiding this comment.
Suggested change
| return apis.ErrInvalidValue(fmt.Errorf("failed to parse the CEL filter: %s", issues.Err()), "cel.filter") | |
| return apis.ErrInvalidValue(fmt.Errorf("failed to parse the CEL overlays: %s", issues.Err()), "cel.overlays") |
| bldr.EventListenerTrigger("tt", "v1alpha1", | ||
| bldr.EventListenerTriggerBinding("tb", "", "tb", "v1alpha1"), | ||
| bldr.EventListenerCELInterceptor("body.value == 'test')"), | ||
| ))), | ||
| }, { |
There was a problem hiding this comment.
Can we add a test case for invalid overlays also
Comment on lines
167
to
168
| _, issues := env.Parse(i.CEL.Filter) | ||
| if issues != nil && issues.Err() != nil { |
There was a problem hiding this comment.
Suggested change
| _, issues := env.Parse(i.CEL.Filter) | |
| if issues != nil && issues.Err() != nil { | |
| if_, issues := env.Parse(i.CEL.Filter); issues != nil && issues.Err() != nil { |
Comment on lines
173
to
174
| _, issues := env.Parse(v.Expression) | ||
| if issues != nil && issues.Err() != nil { |
There was a problem hiding this comment.
Suggested change
| _, issues := env.Parse(v.Expression) | |
| if issues != nil && issues.Err() != nil { | |
| if _, issues := env.Parse(v.Expression); issues != nil && issues.Err() != nil { |
bigkevmcd
force-pushed
the
basic-validation-cel-expression-webhook
branch
from
2a3b374
to
5faaff9
Compare
tekton-robot
added
size/M
|
The following is the coverage report on the affected files.
|
|
Added the reported github issue :) |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: khrm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This does basic syntax checking of CEL interceptor Filters and Overlays.
This would fix this https://tektoncd.slack.com/archives/CKUSJ2A5D/p1599486079009700
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes